Clean up output capture on .NET Core #78205
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This cleans up how we handle output capture on .NET Core. This moves from a lot of mutable `static` static, that would break if tests ran in parallel, to instance state that uses locks to guard againtst concurrent runs.
dotnet-issue-labeler
bot
added
Area-Compilers
untriaged
|
@dotnet/roslyn-compiler PTAL |
jaredpar
removed
the
untriaged
3 tasks
jjonescz
reviewed
Apr 22, 2025
| public interface IRuntimeEnvironment : IDisposable | ||
| { | ||
| (int ExitCode, string Output, string ErrorOutput) Execute(string[] args, int? maxOutputLength); | ||
| (int ExitCode, string Output, string ErrorOutput) Execute(string[] args); |
There was a problem hiding this comment.
Previously the maxOutputLength parameter was used to guard againts infinite loops, seemed useful but it's removed now?
There was a problem hiding this comment.
It was only done on .NET Core though, not .NET Framework. I considered putting the same code path in .NET Framework but that guard hasn't gotten tripped anytime that I remember. Removing the guard means we will still get an exception in an infinite loop, just it will be an OOM exception. So decided to simplify here and remove it.
There was a problem hiding this comment.
fwiw, I've seen that guard hit locally during development, I think.
jjonescz
approved these changes
Apr 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This cleans up how we handle output capture on .NET Core. This moves from a lot of mutable
staticstatic, that would break if tests ran in parallel, to instance state that uses locks to guard againtst concurrent runs.